Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: axios dependeabot alert #3172

Merged
merged 2 commits into from
Jan 8, 2021
Merged

fix: axios dependeabot alert #3172

merged 2 commits into from
Jan 8, 2021

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Jan 5, 2021 •
edited
Loading

Note: it doesn't appear that we support proxy functionality within botbuilder, so I don't think this is a high priority issue deserving patch releases.

@coveralls
Copy link

coveralls commented Jan 5, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 470376550

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.356%
Totals Coverage Status
Change from base Build 467781111: -0.003%
Covered Lines: 17732
Relevant Lines: 20078
💛 - Coveralls

@joshgummersall
Copy link
Contributor Author

Fixes #3173

@joshgummersall joshgummersall linked an issue Jan 7, 2021 that may be closed by this pull request
Upgrade off insecure version of axios and publish to npm #3173
Closed
@joshgummersall joshgummersall merged commit 017f782 into main Jan 8, 2021
@joshgummersall joshgummersall deleted the jpg/bump-axios-dependency branch January 8, 2021 19:39
joshgummersall added a commit that referenced this pull request Jan 13, 2021
@joshgummersall
fix: axios dependeabot alert (#3172)
eae2d00
joshgummersall added a commit that referenced this pull request Jan 13, 2021
@joshgummersall
fix: axios dependeabot alert (#3172)
332ee96
stevengum pushed a commit that referenced this pull request Jan 14, 2021
@joshgummersall
cherrypick(4.10): axios patches (#3185)
6a10236 
* fix: axios dependeabot alert (#3172)

* fix: bump ms-rest-js for axios version bump (#3183)

Fixes #3181
stevengum pushed a commit that referenced this pull request Jan 15, 2021
@joshgummersall
cherrypick(4.11): axios patches (#3184)
f430219 
* fix: axios dependeabot alert (#3172)

* fix: bump ms-rest-js for axios version bump (#3183)

Fixes #3181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade off insecure version of axios and publish to npm
2 participants
@joshgummersall @coveralls