Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: microsoft/botbuilder-dotnet#5084
Description
The MemoryAssertions tests were silently failing. They'll now pass and also elicit errors if they fail. In the Node version, it also was passing the assertions when it shouldn't, due to this, which was correct in Dotnet, which correctly uses
||
. You can see the issues in the original code if you throw a breakpoint hereSpecific Changes
OnError
trigger for the PropertyMock test script. It would otherwise silently swallow errors.