Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MemoryAssertions and test #3180

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Fix MemoryAssertions and test #3180

merged 2 commits into from
Jan 12, 2021

Conversation

mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Jan 8, 2021

Related: microsoft/botbuilder-dotnet#5084

Description

The MemoryAssertions tests were silently failing. They'll now pass and also elicit errors if they fail. In the Node version, it also was passing the assertions when it shouldn't, due to this, which was correct in Dotnet, which correctly uses ||. You can see the issues in the original code if you throw a breakpoint here

Specific Changes

  • Added an OnError trigger for the PropertyMock test script. It would otherwise silently swallow errors.
  • Adjusted what memory properties get written and overwritten.

@coveralls
Copy link

coveralls commented Jan 8, 2021

Pull Request Test Coverage Report for Build 473191049

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 84.377%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive-testing/src/testScript.ts 1 91.78%
Totals Coverage Status
Change from base Build 473110477: 0.003%
Covered Lines: 17746
Relevant Lines: 20090

💛 - Coveralls

@mdrichardson
Copy link
Contributor Author

@chon219 Mind reviewing this? I'd like somebody from the adaptive side to make sure I'm not crazy, if possible. Note: the CI test failure is unrelated.

@chon219 chon219 merged commit d086640 into microsoft:main Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants