Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT]Add test for NumericEvaluator #3262

Merged
merged 2 commits into from
Feb 4, 2021
Merged

[PORT]Add test for NumericEvaluator #3262

merged 2 commits into from
Feb 4, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3258

Description

Add the test for class NumericEvaluator

@Danieladu Danieladu requested review from a team as code owners February 4, 2021 01:10
@coveralls
Copy link

coveralls commented Feb 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 535702513

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 84.605%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 60.47%
libraries/adaptive-expressions/src/triggerTrees/node.ts 10 90.51%
Totals Coverage Status
Change from base Build 534650136: -0.08%
Covered Lines: 18198
Relevant Lines: 20518
💛 - Coveralls

@Danieladu Danieladu merged commit 01545ea into main Feb 4, 2021
@Danieladu Danieladu deleted the hond/addtest branch February 4, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Add test for NumericEvaluator (#5139)
3 participants
@Danieladu @coveralls @joshgummersall