-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Teams Meeting Notification interface structure changes #4416
fix: Teams Meeting Notification interface structure changes #4416
Conversation
Pull Request Test Coverage Report for Build 4108444092
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR review: leaving a few comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A follow up comment :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you :)
* type structure changes, tested * yarn lint fix * name change * name change' * name change * update MeetingOnBehalfOf to just OnBehalfOf * changes * moved channelData to child interface
Fixes #4415
Description
sendMeetingNotification
api call, so that it can be extended without any breaking changes. And by 'extend`, I mean adding new types, making-optional existing properties and adding properties to existing interfaces.Specific Changes
channelData
an optional propertyonBehalfOf
property to be a list ofMeetingOnBehalfOf
objects.notification
parameter insendMeetingNotification
API function isMeetingNotification
. Currently it is equal toTargetedMeetingNotification
. However it can made be a union of any arbitrary type. This makes the payload type extensible without any breaking changes.value
property would be serialized without any hard coded constraints.surfaces
now is a list ofMeetingSurface
type. Just likeMeetingNotification
it can be a union of any arbitrary type. Making it possible to have more than one type of surface object in the list of surfaces.TeamsMeeting
prefixed type names are not justMeeting
. This conforms to the standards of meetings-related type within the SDK.Testing