Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add check to handle bad values in Orchestrator botState.ts #4425

Merged
merged 3 commits into from
Feb 7, 2023
Merged

fix: Add check to handle bad values in Orchestrator botState.ts #4425

merged 3 commits into from
Feb 7, 2023

Conversation

anishprasad01
Copy link
Contributor

@anishprasad01 anishprasad01 commented Jan 31, 2023 •
edited
Loading

Fixes #4423
Thanks to @tdurnford for help with this.

Description

Adds a check for null values in botState.ts which was allowing null to pass through.

Specific Changes

  • Added value === null to the check on line 228.

Testing

  • Tested in a sample bot and successfully connected to the skill
  • Passed tests
    image

@anishprasad01 anishprasad01 added Automation: No parity PR does not need to be applied to other languages. Area: AI-Orchestrator The issue is related to Orchestrator labels Jan 31, 2023
@anishprasad01 anishprasad01 self-assigned this Jan 31, 2023
@coveralls
Copy link

coveralls commented Feb 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4067547742

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 84.654%
Totals Coverage Status
Change from base Build 4055439132: -0.002%
Covered Lines: 20002
Relevant Lines: 22391
💛 - Coveralls

@anishprasad01 anishprasad01 marked this pull request as ready for review February 1, 2023 18:51
@anishprasad01 anishprasad01 requested a review from a team as a code owner February 1, 2023 18:51
@johnataylor johnataylor merged commit 6e11d14 into main Feb 7, 2023
@johnataylor johnataylor deleted the anishprasad01/orchestrator-null-fix branch February 7, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

@tracyboehrer tracyboehrer Awaiting requested review from tracyboehrer

Assignees

@anishprasad01 anishprasad01

Labels
Area: AI-Orchestrator The issue is related to Orchestrator Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composer bot using the Orchestrator recognizer fails with null error on 4.18.0 and greater
3 participants
@anishprasad01 @coveralls @johnataylor