-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update channelServiceRoutes to add next() parameter to support restify 10.0.0+ #4429
Merged
anishprasad01
merged 4 commits into
main
from
anishprasad01/restify-10-compatibility-update
Feb 16, 2023
Merged
fix: Update channelServiceRoutes to add next() parameter to support restify 10.0.0+ #4429
anishprasad01
merged 4 commits into
main
from
anishprasad01/restify-10-compatibility-update
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishprasad01
added
customer-reported
Issue is created by anyone that is not a collaborator in the repository.
Bot Services
Required for internal Azure reporting. Do not delete. Do not change color.
Area: Skills
The issue is related to skills
Automation: No parity
PR does not need to be applied to other languages.
labels
Feb 9, 2023
anishprasad01
changed the title
Update channelServiceRoutes to add next() parameter to support restify 10.0.0+
fix: Update channelServiceRoutes to add next() parameter to support restify 10.0.0+
Feb 9, 2023
Pull Request Test Coverage Report for Build 4168147444
💛 - Coveralls |
we need to first verify that this change doesn't break existing Node and Restify dependencies |
Tested the code as of most recent commit in Sample 81 with |
johnataylor
approved these changes
Feb 16, 2023
anishprasad01
deleted the
anishprasad01/restify-10-compatibility-update
branch
February 16, 2023 22:36
tracyboehrer
pushed a commit
that referenced
this pull request
Mar 21, 2023
…estify 10.0.0+ (#4429) * Add next callback to support restify chain handler * Update next type and channelServiceRoutes tests * Remove return next() to fix Headers Sent Error * Add return next() in the handler function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Skills
The issue is related to skills
Automation: No parity
PR does not need to be applied to other languages.
Bot Services
Required for internal Azure reporting. Do not delete. Do not change color.
customer-reported
Issue is created by anyone that is not a collaborator in the repository.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Fixes Internal: https://portal.microsofticm.com/imp/v3/incidents/details/365652257/home
Description
restify 10.0.0 and greater enforces the need for a
next()
callback that passes execution to the next function in the handler chain.channelServiceRoutes.ts
does not currently address this requirement. Since this class is required to interact with skills, this means that root bots that import this class will fail to start.Specific Changes
next: Function
parameter to the handlers inchannelServiceRoutes.ts
return next()
statement to the aforementioned handlerschannelServiceRoutes.test.js
to pass in an emptyFunction
asnext
in each testTesting
Ran the updated unit tests successfully.