-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Teams Adaptive cards in QnA Dialog #4467
Conversation
Pull Request Test Coverage Report for Build 5062720546
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small details. Same that the .NET PR, we could add tests to cover the new code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anishprasad01, why are all those docs necessary? The rest of the changes look good.
The pipeline checks required they be generated. I simply ran the script to create them. |
The only doc requested is |
Fixes Internal IcM Issue #373550043
Fixes #4476
Description
This PR allows for choosing Adaptive Cards formatted for use in Microsoft Teams instead of the default Hero Cards. This is done to support markdown formatting in QnA and CQA responses since Teams only supports markdown in Adaptive Cards. Changes are made in
qnaCardBuilder.ts
andqnaMakerDialog.ts
.Using the new cards simple requires adding code in the bot to take in a new environment variable:
UseTeamsAdaptiveCard = "true"
and pass it to the QnA dialog constructor. If no changes are made, the bot will default to a Hero card.Specific Changes
Testing
Tests ran successfully.