Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#4481] Outgoing Activity Locale being Overwritten #4489

Merged
merged 4 commits into from
Jul 14, 2023
Merged

port: [#4481] Outgoing Activity Locale being Overwritten #4489

merged 4 commits into from
Jul 14, 2023

Conversation

ceciliaavila
Copy link
Collaborator

@ceciliaavila ceciliaavila commented Jun 14, 2023 •
edited
Loading

Fixes #4481

Description

This PR modifies the TurnContext's applyConversationReference method to avoid the activity's locale from being overwritten by the reference locale.

Specific Changes

  • Updated applyConversationReference method in TurnContext class to use the activity's locale first. If it's null, use the reference's locale.
  • Updated unit tests to assert the right locale values.

Testing

The following images show how the activity's locale is not being overwritten.
image
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner June 14, 2023 17:58
@ceciliaavila ceciliaavila linked an issue Jun 14, 2023 that may be closed by this pull request
port: [#5820] Outgoing Activity Locale being Overwritten #4481
Closed
@ceciliaavila ceciliaavila changed the title port: [#5820] Outgoing Activity Locale being Overwritten port: [#4481] Outgoing Activity Locale being Overwritten Jun 14, 2023
@coveralls
Copy link

coveralls commented Jun 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5270522572

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.868%
Totals Coverage Status
Change from base Build 5222839148: 0.4%
Covered Lines: 20119
Relevant Lines: 22476
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 6cae128 into main Jul 14, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/activitylocale-overwriting branch July 14, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: [#5820] Outgoing Activity Locale being Overwritten
4 participants
@ceciliaavila @coveralls @tracyboehrer @JhontSouth