Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug that two strings can share the same hash code #1298

Conversation

hcyang
Copy link
Contributor

@hcyang hcyang commented Sep 20, 2021

Fix #1297

@munozemilio munozemilio merged commit fcb2cdb into main Sep 20, 2021
@munozemilio munozemilio deleted the hunyang/BF_LU_parser_luisCollate_BotframeworkBfLuLuisCollateMergeCanLeadToCollision branch September 20, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In luisCollate.js, the mergeResultsWithHash uses a hash code/table that can lead to collision
3 participants