Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to support Luis schema v6.0.0 #534

Merged
merged 15 commits into from
Mar 6, 2020
Merged

Changes to support Luis schema v6.0.0 #534

merged 15 commits into from
Mar 6, 2020

Conversation

axelsrz
Copy link
Member

@axelsrz axelsrz commented Feb 5, 2020 •
edited
Loading

fixes #453

@axelsrz axelsrz changed the title initial changes to suppor 6.0.0 Changes to suppor 6.0.0 Feb 11, 2020
@munozemilio
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@axelsrz axelsrz changed the title Changes to suppor 6.0.0 Changes to support Luis schema v6.0.0 Feb 11, 2020
@chrimc62
Copy link
Contributor

My only feedback is where are the tests?

chrimc62
chrimc62 approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rurounijones
Copy link

Ahoi all. This has been sitting in limbo for nearly 3 weeks. Is there an ETA / priority for this?

@axelsrz axelsrz marked this pull request as ready for review March 4, 2020 04:27
@munozemilio
Copy link
Member

munozemilio commented Mar 4, 2020 •
edited
Loading

Build is fixed but I think some tests are missing

munozemilio
munozemilio previously requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

@axelsrz axelsrz dismissed munozemilio’s stale review March 6, 2020 07:58

Changes addressed

@axelsrz axelsrz merged commit 2c061ae into master Mar 6, 2020
@axelsrz axelsrz deleted the axsuarez/luisgen-schema-6.0.0 branch March 6, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrimc62 chrimc62 chrimc62 approved these changes

@munozemilio munozemilio munozemilio left review comments

@vishwacsena vishwacsena Awaiting requested review from vishwacsena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LUISgen generates bad C# files from JSON app file
4 participants
@axelsrz @munozemilio @chrimc62 @rurounijones