Nigao/renaming #573
Merged
Nigao/renaming #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimc62
suggested changes
Feb 14, 2020
There was a problem hiding this comment.
Thanks for doing this!
- We should have a generator.lg template which takes the entity name like for geographyv2. That way we centralize where the naming happens for all templates.
- To be consistent, we should name Confirmation as ConfirmationEntity just to make clear it is an entity and rename the other built-in template entities as well.
- I also think we should add intent, i.e. library-HelpIntent, library-NoneIntent. Makes it clearer what is going on.
Also, when you finish, I will sync to fix up the tests which are failing.
chrimc62
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.