Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LUIS JSON to LU to handle hierarchical entities correctly #921

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

vishwacsena
Copy link
Contributor

Fixes #920

@codecov-commenter
Copy link

Codecov Report

Merging #921 into master will decrease coverage by 4.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   60.38%   55.71%   -4.68%     
==========================================
  Files         220      219       -1     
  Lines       18686    16275    -2411     
  Branches     2475     2335     -140     
==========================================
- Hits        11284     9068    -2216     
+ Misses       6803     6623     -180     
+ Partials      599      584      -15     
Impacted Files Coverage Δ
packages/lu/src/parser/luis/luConverter.js 86.18% <100.00%> (-3.14%) ⬇️
packages/command/src/readpipeddata.ts 65.21% <0.00%> (-18.12%) ⬇️
packages/config/src/commands/config/index.ts 60.00% <0.00%> (-15.00%) ⬇️
...kages/luis/src/commands/luis/application/create.ts 60.00% <0.00%> (-13.34%) ⬇️
packages/lg/src/commands/lg/index.ts 66.66% <0.00%> (-11.12%) ⬇️
packages/qnamaker/src/commands/qnamaker/index.ts 66.66% <0.00%> (-11.12%) ⬇️
...ages/lu/src/parser/qna/alterations/qnaConverter.js 40.00% <0.00%> (-10.00%) ⬇️
packages/luis/src/commands/luis/version/import.ts 75.00% <0.00%> (-9.79%) ⬇️
packages/qnamaker/src/commands/qnamaker/init.ts 86.20% <0.00%> (-9.63%) ⬇️
packages/luis/src/commands/luis/cross-train.ts 77.27% <0.00%> (-9.62%) ⬇️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e144c...deec8da. Read the comment docs.

@munozemilio munozemilio merged commit ec5bb0e into master Aug 5, 2020
@munozemilio munozemilio deleted the vishwac/920 branch February 12, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchical entities are not parsed correctly
3 participants