Fix #2146: SWIPE DELETE FUNCTION FREEZES APP #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzhang54
approved these changes
Apr 11, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tian-lt
added a commit
that referenced
this pull request
Apr 28, 2024
Merged
tian-lt
added a commit
that referenced
this pull request
Apr 28, 2024
* Fix #2146: SWIPE DELETE FUNCTION FREEZES APP (#2157) * fix stackoverflow * space * Multi-instance (#2161) * launch multi instances * trace error * simplify the graphing test * remove an assertion * simplify some code * remove some trivial code. * fix runtime cast * Resize on the first launch (#2165)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2146
Root cause
Stackoverflow when removing a history item by swiping.
SetChildAsHistory()has side effects even if the current panel is History already. PR #2116 addedUpdateHistoryStateinto the callback of propertychanged, which forms a cycle of the implicit invocations trigged by databinding.Fix
Make sure
SetChildAsHistory()has no side effects if there nothing to change.Updated
SetChildAsMemory()accordingly.