Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the application to crash when the current page is Date Calculation and users paste a text #391

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Prevent the application to crash when the current page is Date Calculation and users paste a text #391

merged 2 commits into from
Apr 15, 2019

Conversation

rudyhuyn
Copy link
Contributor

Fixes #389

Description of the changes:

  • Fix the else condition in ApplicationViewModel::OnPaste

How changes were validated:

Manually

HowardWolosky
HowardWolosky suggested changes Mar 27, 2019
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I checked the file, and it doesn't look like there are any other instances where we might hit this. Thanks again.

src/CalcViewModel/ApplicationViewModel.cpp Outdated Show resolved Hide resolved
@HowardWolosky HowardWolosky self-assigned this Mar 27, 2019
@HowardWolosky
Copy link
Member

@rudyhuyn - Just looking for a minor update to this, and then we can get it merged in.
Thanks!

@HowardWolosky @rudyhuyn
fix spacing
9e8611d 
Co-Authored-By: rudyhuyn <rudyhuyn@gmail.com>
HowardWolosky
HowardWolosky approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that update.

@HowardWolosky HowardWolosky merged commit 5a6c6f4 into microsoft:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardWolosky HowardWolosky HowardWolosky approved these changes

Assignees

@HowardWolosky HowardWolosky

Labels
Bug Issue is a bug fixing approved issue needs author feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The application crashes when users press ctrl+V while displaying the Date Calculation page.
2 participants
@rudyhuyn @HowardWolosky