Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide or Disable graphing calculator menu item when necessary #848

Merged
merged 5 commits into from
Dec 6, 2019
Merged

Hide or Disable graphing calculator menu item when necessary #848

merged 5 commits into from
Dec 6, 2019

Conversation

rudyhuyn
Copy link
Contributor

@rudyhuyn rudyhuyn commented Dec 5, 2019 •
edited
Loading

Hide the graphing calculator menu item when the OS doesn't support the feature or disable it when a group policy is set.

Description of the changes:

  • Hide the Graphing Calculator menu when running Windows versions prior to Vibranium
  • Disable the Graphing Calculator menu when a group policy is set
  • Switch to the default view (Standard mode) when Graphing Calculator was the last used feature but the feature was disable later by the group policy
  • modify accelerator keys of Programmer mode and Date Calculation if the Graphing Calculator menu item is visible or not (3 and 4 or 4 and 5)

Also:

  • simplify NavCategory class
  • remove NavCategory::Position (never used)

How changes were validated:

  • manually

@rudyhuyn rudyhuyn requested a review from EriWong December 5, 2019 08:27
@sanderl sanderl added the graphing calculator Work items related to the graphing calculator feature. label Dec 5, 2019
mcooley
mcooley reviewed Dec 6, 2019
View reviewed changes
src/CalcViewModel/Common/NavCategory.cpp
HKEY_LOCAL_MACHINE,
L"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Policies\\Calculator",
L"AllowGraphingCalculator",
RRF_RT_REG_DWORD | RRF_RT_REG_BINARY,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RRF_RT_DWORD

EriWong
EriWong approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@EriWong EriWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and local buddy testing passed :)

@rudyhuyn rudyhuyn merged commit 5038318 into microsoft:feature/GraphingCalculator Dec 6, 2019
@rudyhuyn rudyhuyn deleted the hideGraph branch December 6, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcooley mcooley mcooley left review comments

@EriWong EriWong EriWong approved these changes

Assignees

@EriWong EriWong

Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rudyhuyn @mcooley @EriWong @sanderl