Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move variables to the right column #859

Merged
merged 7 commits into from
Dec 12, 2019
Merged

Move variables to the right column #859

merged 7 commits into from
Dec 12, 2019

Conversation

rudyhuyn
Copy link
Contributor

Description of the changes:

  • Remove the variable popup + button
  • Display variables in the right column
  • Polish design of variable editor

Also:

  • Fix tab navigation when there is more than one equation listed

How changes were validated:

  • Manually with light, dark and high contrast themes

joseartrivera
joseartrivera requested changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I left a few comments, not sure if some are related to this PR, if not we can address them as bugs separately. Thanks!

src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp Show resolved Hide resolved
@joseartrivera joseartrivera self-assigned this Dec 11, 2019
@ghost ghost removed the needs author feedback label Dec 12, 2019
joseartrivera
joseartrivera previously approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs to resolve the merge conflicts and then we can merge it!

@joseartrivera joseartrivera merged commit da38b5a into microsoft:feature/GraphingCalculator Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseartrivera joseartrivera joseartrivera approved these changes

Assignees

@joseartrivera joseartrivera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudyhuyn @joseartrivera