Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign graph buttons + replace ActiveTracing button by a ToggleButton #864

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Redesign graph buttons + replace ActiveTracing button by a ToggleButton #864

merged 2 commits into from
Dec 12, 2019

Conversation

rudyhuyn
Copy link
Contributor

Description of the changes:

  • Modify design of Graph buttons (border added, thinner, circles removed, pointerover/press states modified)
  • Replace ActiveTracing button by a ToggleButton
  • Leave the active tracing mode using the Escape key
  • Simplify how we manage the tooltip of the ActiveTracing button

image

How changes were validated:

  • Manually with light, dark and high contrast themes with batter saver on and off.

@rudyhuyn rudyhuyn changed the base branch from master to feature/GraphingCalculator December 12, 2019 01:51
joseartrivera
joseartrivera reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good! I found a few issues that we will want to address, let me know what you think. Thanks again!! :)

src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Outdated Show resolved Hide resolved
@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Dec 12, 2019
joseartrivera
joseartrivera approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think the pointer over state for the buttons are still opposite from the rest of the buttons in Windows, but maybe I am mistaken. Thanks for the improvements!

@joseartrivera joseartrivera merged commit f282605 into microsoft:feature/GraphingCalculator Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseartrivera joseartrivera joseartrivera approved these changes

Assignees

@joseartrivera joseartrivera

Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudyhuyn @joseartrivera