Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to note that PowerShell Core 6+ is required #400

Closed
gitri-ms opened this issue Sep 25, 2023 · 1 comment
Closed

Update README to note that PowerShell Core 6+ is required #400

gitri-ms opened this issue Sep 25, 2023 · 1 comment
Assignees
@gitri-ms
Labels
documentation Improvements or additions to documentation sk team issue

Comments

@gitri-ms
Copy link
Collaborator

Our PowerShell scripts were written for PowerShell Core 6+, which is the "new" cross-platform version of PowerShell. However, it is does need to be installed separately and is different from the legacy PowerShell that is bundled with Windows. Our README should explicitly note this in the instructions for using the scripts.
@gitri-ms gitri-ms added the documentation Improvements or additions to documentation label Sep 25, 2023
@gitri-ms gitri-ms self-assigned this Sep 25, 2023
@dehoward dehoward mentioned this issue Sep 25, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 26, 2023
@dehoward
Update readme for PowerShell Core 6+ (#401)
b427b6f 
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
addresses #400 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
@dehoward dehoward moved this from Ready to Done in Apps & Services Semantic Kernel Sep 26, 2023
@dehoward
Copy link
Contributor

fixed by #401

teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this issue Oct 7, 2024
@dehoward
Update readme for PowerShell Core 6+ (microsoft#401)
d45e101 
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
addresses microsoft#400 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitri-ms gitri-ms

Labels
documentation Improvements or additions to documentation sk team issue
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gitri-ms @dehoward