Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app registration link in README #142

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Aug 9, 2023

Motivation and Context

The link to the application registration section has become zombied.

Description

Re-targeted existing reference.

Contribution Checklist

@crickman crickman self-assigned this Aug 9, 2023
@crickman crickman linked an issue Aug 9, 2023 that may be closed by this pull request
@github-actions github-actions bot added documentation Improvements or additions to documentation PR: ready for review labels Aug 9, 2023
@dehoward dehoward changed the title Update Fix app registration link in README Aug 9, 2023
@crickman crickman requested a review from momuno August 9, 2023 19:36
@crickman crickman added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 1ed63be Aug 9, 2023
5 checks passed
@crickman crickman deleted the fix-doclink-appregistration branch August 9, 2023 20:03
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

<!-- Thank you for your contribution to the copilot-chat repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

The link to the application registration section has become zombied.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Re-targeted existing reference.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Documentation about AAD config is confusing
3 participants