Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number information in backend, frontend and build process #165

Merged
merged 11 commits into from
Aug 16, 2023
Merged

Add version number information in backend, frontend and build process #165

merged 11 commits into from
Aug 16, 2023

Conversation

glahaye
Copy link
Collaborator

@glahaye glahaye commented Aug 14, 2023

Motivation and Context

We want to make it easier to know which version we are dealing with / debugging

Description

  • Add version number information in backend, frontend and build process
  • Remove unused deployment files

image

Contribution Checklist

@github-actions github-actions bot added webapp Pull requests that update Typescript code webapi Pull requests that update .net code deployment Issues related to deploying Chat-Copilot PR: ready for review github actions Pull requests that update GitHub Actions code labels Aug 14, 2023
webapi/Controllers/ServiceOptionsController.cs Outdated Show resolved Hide resolved
webapi/Models/Response/ServiceOptionsResponse.cs Outdated Show resolved Hide resolved
webapi/Models/Response/ServiceOptionsResponse.cs Outdated Show resolved Hide resolved
.github/workflows/typos.yaml Outdated Show resolved Hide resolved
.github/workflows/copilot-build-frontend.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@teresaqhoang teresaqhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the version bumped automatically? Or is this something we have to do manually? If the latter, we should specify this in a contributing doc somewhere

should also start a version changelog in this PR

scripts/deploy/deploy-webapp.ps1 Outdated Show resolved Hide resolved
scripts/deploy/package-webapi.ps1 Show resolved Hide resolved
scripts/deploy/deploy-webapp.ps1 Outdated Show resolved Hide resolved
scripts/deploy/deploy-webapp.sh Outdated Show resolved Hide resolved
@glahaye
Copy link
Collaborator Author

glahaye commented Aug 15, 2023

Is the version bumped automatically? Or is this something we have to do manually? If the latter, we should specify this in a contributing doc somewhere

should also start a version changelog in this PR

For proper Releases and change logs, we can use functionality baked in GitHub already. This PR is but a step for that to happen. Stay tuned.

@glahaye
Copy link
Collaborator Author

glahaye commented Aug 16, 2023

so with that said, we will have automatic updating of the major/minors in the future? I have concerns about having to manually update these fields, but they are alleviated if Github will does it for us 😄

OK, let me try to build this in this PR, then!

For reference:
https://github.com/microsoft/chat-copilot/releases

@glahaye glahaye added this pull request to the merge queue Aug 16, 2023
Merged via the queue into microsoft:main with commit ec8a7d6 Aug 16, 2023
7 checks passed
@glahaye glahaye deleted the bake_in_version branch August 16, 2023 17:07
github-merge-queue bot pushed a commit that referenced this pull request Aug 16, 2023
### Motivation and Context
I introduced a bug with
#165 in the frontend
deployment script

### Description
Use proper Unix commands in the shell script

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
…microsoft#165)

### Motivation and Context
We want to make it easier to know which version we are dealing with /
debugging

### Description

- Add version number information in backend, frontend and build process
- Remove unused deployment files


![image](https://github.com/microsoft/chat-copilot/assets/8430998/57112301-16d6-4bd1-ac1d-d67253976f1e)


### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Issues related to deploying Chat-Copilot github actions Pull requests that update GitHub Actions code webapi Pull requests that update .net code webapp Pull requests that update Typescript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants