-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-ordered plug-in result to be included _after_ chat-history #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
webapi
Pull requests that update .net code
PR: ready for review
labels
Aug 15, 2023
crickman
changed the title
Updated
Re-ordered plug-in result to be included _after_ chat-history
Aug 15, 2023
alliscode
previously approved these changes
Aug 15, 2023
TaoChenOSU
reviewed
Aug 15, 2023
TaoChenOSU
reviewed
Aug 15, 2023
glahaye
approved these changes
Aug 17, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…oft#182) ### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Customer reported stale plug-in results. Re-ordering prompt to include plug-in results last may impact prioritizing this data for certain cases. (Isolated testing indicates that the model can respond to priority hints via ordering, but other factors may influence model behavior as well...such as chat history or memory presenting stronger semantic context.) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Move planner results to after chat-history: ``` [SOURCE START] This is the result of invoking the functions listed after "PLUGINS USED:" to retrieve additional information outside of the data you were trained on. You can use this data to help answer the user's query. PLUGINS USED: ListPluginPlugin.GetList. RESULT: { "content": "eba26d18-b4bb-46d4-b6b6-cbf60d4312e8\n12ed4781-5b22-48a0-b4e9-a351e546e7ff\n90605eb2-51ce-4058-8ae0-dfbe5ed455f7\nf51d2923-f97a-41b8-97d4-991b9f46e260", "contentType": "text/plain" } [SOURCE END] ``` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Customer reported stale plug-in results. Re-ordering prompt to include plug-in results last may impact prioritizing this data for certain cases. (Isolated testing indicates that the model can respond to priority hints via ordering, but other factors may influence model behavior as well...such as chat history or memory presenting stronger semantic context.)
Description
Move planner results to after chat-history:
Contribution Checklist