Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem when sqlAdminPassword is not provided #207

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fix problem when sqlAdminPassword is not provided #207

merged 1 commit into from
Aug 18, 2023

Conversation

glahaye
Copy link
Collaborator

@glahaye glahaye commented Aug 17, 2023

Motivation and Context

deploy-azure.ps1 gave the following error when no sqlAdminPassword value was provided:
Cannot process argument transformation on parameter 'SqlAdminPassword'. Cannot convert the "" value of type "System.String" to type "System.Security.SecureString".

Description

Use null value instead of an empty string

Contribution Checklist

@github-actions github-actions bot added deployment Issues related to deploying Chat-Copilot PR: ready for review labels Aug 17, 2023
@glahaye glahaye added this pull request to the merge queue Aug 18, 2023
Merged via the queue into microsoft:main with commit 55dfb3c Aug 18, 2023
5 checks passed
@glahaye glahaye deleted the sqlAdminPassword_fix branch August 18, 2023 07:38
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context
deploy-azure.ps1 gave the following error when no sqlAdminPassword value
was provided:
Cannot process argument transformation on parameter 'SqlAdminPassword'.
Cannot convert the "" value of type "System.String" to type
"System.Security.SecureString".

### Description
Use  null value instead of an empty string

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Issues related to deploying Chat-Copilot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants