Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Null Reference on Content-Saftey service #222

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Conversation

crickman
Copy link
Contributor

Motivation and Context

Reported by customer in #218

Description

Use null-coalesce operator to return false when service null

Contribution Checklist

@crickman crickman added bug Something isn't working webapi Pull requests that update .net code PR: ready for review external dependency issue Issues related to external dependencies (e.g. Azure) labels Aug 20, 2023
@crickman crickman self-assigned this Aug 20, 2023
@crickman crickman requested a review from a team August 20, 2023 19:44
@crickman crickman added this pull request to the merge queue Aug 20, 2023
Merged via the queue into main with commit d5a0d46 Aug 20, 2023
6 checks passed
@crickman crickman deleted the fix-nullref-cntsfty branch August 20, 2023 23:05
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

<!-- Thank you for your contribution to the copilot-chat repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Reported by customer in
microsoft#218

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Use null-coalesce operator to return false when service null

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external dependency issue Issues related to external dependencies (e.g. Azure) webapi Pull requests that update .net code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Post latest changes, the app breaks if ContentSafety is disabled in appsettings.
2 participants