Fix formatting of Aad url in react env variables #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this matches the behavior of the .ps1 script and the default values in scripts/.env
crickman
added
the
external dependency issue
glahaye
approved these changes
Sep 6, 2023
gitri-ms
approved these changes
Sep 6, 2023
|
Thanks @jimmystridh for catching this! |
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context The powershell script does not include the protocol when generating the `REACT_APP_AAD_AUTHORITY` environment variable and the .env file default is based on this notion. Without this fix, the resulting webapp/.env will look something like this: ``` > cat webapp/.env REACT_APP_BACKEND_URI=https://localhost:40443/ REACT_APP_AUTH_TYPE=AzureAd REACT_APP_AAD_AUTHORITY=https://https://login.microsoftonline.com/XXX ``` so the protocol will be duplicated into an invalid url. ### Description The change removes the prefixing `https://` in the `configure.sh` script to match the behavior of the `Configure.ps1` script. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The powershell script does not include the protocol when generating the
REACT_APP_AAD_AUTHORITYenvironment variable and the .env file default is based on this notion.Without this fix, the resulting webapp/.env will look something like this:
so the protocol will be duplicated into an invalid url.
Description
The change removes the prefixing
https://in theconfigure.shscript to match the behavior of theConfigure.ps1script.Contribution Checklist