Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deploy-webapi do all it needs to by default #524

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Make deploy-webapi do all it needs to by default #524

merged 5 commits into from
Oct 20, 2023

Conversation

glahaye
Copy link
Collaborator

@glahaye glahaye commented Oct 19, 2023

Motivation and Context

Some switches need to be included at the command line to ensure proper modification of the AAD app registration and addition of our URIs to the plugin CORS. These steps should be done by default.

Description

Make all required steps run by default.
Fixed population of frontend version info

Contribution Checklist

@github-actions github-actions bot added deployment Issues related to deploying Chat-Copilot github actions Pull requests that update GitHub Actions code labels Oct 19, 2023
@github-actions github-actions bot added the webapp Pull requests that update Typescript code label Oct 20, 2023
@glahaye glahaye mentioned this pull request Oct 20, 2023
@glahaye glahaye added this pull request to the merge queue Oct 20, 2023
Merged via the queue into microsoft:main with commit 1de50cc Oct 20, 2023
6 checks passed
@glahaye glahaye deleted the positive_logic branch October 20, 2023 03:36
Ryangr0 pushed a commit to webgrip/chat-copilot that referenced this pull request Oct 26, 2023
### Motivation and Context
Some switches need to be included at the command line to ensure proper
modification of the AAD app registration and addition of our URIs to the
plugin CORS. These steps should be done by default.

### Description
Make all required steps run by default.
Fixed population of frontend version info

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context
Some switches need to be included at the command line to ensure proper
modification of the AAD app registration and addition of our URIs to the
plugin CORS. These steps should be done by default.

### Description
Make all required steps run by default.
Fixed population of frontend version info

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Issues related to deploying Chat-Copilot github actions Pull requests that update GitHub Actions code webapp Pull requests that update Typescript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants