Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenCount performance issues #580

Merged
merged 1 commit into from
Nov 7, 2023
Merged

TokenCount performance issues #580

merged 1 commit into from
Nov 7, 2023

Conversation

JohanYman
Copy link
Contributor

Motivation and Context

We encountered some performance issues and implemented the following fix.

Description

We updated the TokenUtils class within the Skills Web API to address these issues. A newly-introduced tokenizer has been implemented for encoding text, which significantly improves the efficiency of the TokenCount method. As a result of this change, the performance of the token counting operations has been enhanced, ensuring more accurate and faster responses for users.

Contribution Checklist

…fix. We updated the TokenUtils class within the Skills Web API to address these issues. A newly-introduced tokenizer has been implemented for encoding text, which significantly improves the efficiency of the TokenCount method. As a result of this change, the performance of the token counting operations has been enhanced, ensuring more accurate and faster responses for users.
@github-actions github-actions bot added the webapi Pull requests that update .net code label Nov 7, 2023
@JohanYman JohanYman changed the title We encountered some performance issues and implemented the following … TokenCount performance issues Nov 7, 2023
@crickman
Copy link
Contributor

crickman commented Nov 7, 2023

Thank you for contributing this impactful update!

@crickman crickman added this pull request to the merge queue Nov 7, 2023
Merged via the queue into microsoft:main with commit 39edfcc Nov 7, 2023
7 checks passed
@JohanYman JohanYman deleted the TokenUtils-performace-fix branch November 8, 2023 14:40
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

We encountered some performance issues and implemented the following
fix.

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

We updated the TokenUtils class within the Skills Web API to address
these issues. A newly-introduced tokenizer has been implemented for
encoding text, which significantly improves the efficiency of the
TokenCount method. As a result of this change, the performance of the
token counting operations has been enhanced, ensuring more accurate and
faster responses for users.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapi Pull requests that update .net code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants