Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: invoked operation continuation of running state #335

Closed
kevinhillinger opened this issue Jun 12, 2023 · 1 comment · Fixed by #338
Closed

Bug: invoked operation continuation of running state #335

kevinhillinger opened this issue Jun 12, 2023 · 1 comment · Fixed by #338
Assignees
@kevinhillinger
Labels
bug Something isn't working v1

Comments

@kevinhillinger
Copy link
Member

No description provided.

@kevinhillinger kevinhillinger added bug Something isn't working v1 labels Jun 12, 2023
@kevinhillinger
Copy link
Member Author

now there's a OperationTask type

  • object has Run and Continue methods
  • removed running condition from is executable
  • Implemented every Operation operation struct as implementing a OperationTask with both Run and Continue methods so it's explicit on continue for each
  • modified the provider to return the OperationTask type instead of an OperationFunc
  • Operation determines if it's a continuation and selects the Continue function. Since everything in the Operator must implement both Run and Continue it's guaranteed to be there

@kevinhillinger kevinhillinger self-assigned this Jun 12, 2023
@kevinhillinger kevinhillinger mentioned this issue Jun 13, 2023
Merged
@kevinhillinger kevinhillinger linked a pull request Jun 13, 2023 that will close this issue
v1 - fix #335 #338
Merged
bobjac pushed a commit that referenced this issue Jun 13, 2023
@kevinhillinger
v1 - fix #335 (#338)
c3c25f4 
* implementation with OperationTask that has { Run, Continue } functions

* removing running from condition of executable on the operation

* wiring up operation scheduler to dispatch/schedule operations to continue on the event of a restart of the operator

* continue now functioning on restart

* dryrun continue impl

* continue for deploy

* continue for deploystage

* defaulting for retry and retry stage

* continuation on restart, adjusting query and adding event types of Pending for deployment and stage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinhillinger kevinhillinger

Labels
bug Something isn't working v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1 - fix #335 microsoft/commercial-marketplace-offer-deploy
1 participant
@kevinhillinger