Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API to populate raw Common Schema 4.0 fields #1

Closed
maxgolov opened this issue Jun 11, 2019 · 2 comments
Closed

New API to populate raw Common Schema 4.0 fields #1

maxgolov opened this issue Jun 11, 2019 · 2 comments
Assignees
Labels
EDGE Partner Team - Microsoft Edge enhancement New feature or request

Comments

@maxgolov
Copy link
Contributor

There are several fields that cannot be currently populated by SDK. Example:

  • ext.app.env
  • ext.container
  • etc.

Feature request:

  • add new CS4.0 fields definition and regenerate the C++ bond-related code
  • introduce a generic schema mapping mechanism that would allow to expose any new CS protocol field via SetProperty and SetContext API to the app caller

Request comes from MS Edge team.

@maxgolov maxgolov self-assigned this Jun 11, 2019
@maxgolov maxgolov added the enhancement New feature or request label Jun 11, 2019
@maxgolov maxgolov added this to the Vibranium - 08.August milestone Jun 18, 2019
@maxgolov
Copy link
Contributor Author

This is also identical to MS Edge team ask "CS 3.0: Need a general method for updating all CS 3.0 optional fields." tracked under Task 22164965.

@maxgolov maxgolov added the EDGE Partner Team - Microsoft Edge label Jun 24, 2019
@maxgolov maxgolov removed this from the Vibranium - 10.October milestone Sep 30, 2019
@maxgolov
Copy link
Contributor Author

maxgolov commented Oct 4, 2019

As discussed in several other threads: currently there is no more practical need to add more semantic APIs for individual common schema fields. Instead there's a new custom decorator pattern that allows to efficiently adjust the raw Common Schema Protocol Record fields. Customers who know they use Common Schema, and need to set specific schema field value - can use this pattern to populate the fields.

Example:

class CustomDecorator: public IDecoratorModule

I'm closing this issue in favor a custom decorator concept suggested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EDGE Partner Team - Microsoft Edge enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant