Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Routing to DataShaperApp #433

Merged
merged 7 commits into from
Nov 21, 2022
Merged

Add Routing to DataShaperApp #433

merged 7 commits into from
Nov 21, 2022

Conversation

darthtrevino
Copy link
Member

No description provided.

@darthtrevino darthtrevino requested a review from a team as a code owner November 21, 2022 22:15
natoverse
natoverse approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@natoverse natoverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good so far

javascript/app-framework/src/components/DataShaperApp/DataShaperApp.hooks.ts Show resolved Hide resolved
javascript/app-framework/src/components/resources/FileTree/FileTree.types.ts Show resolved Hide resolved
javascript/app-framework/src/components/resources/FileTree/groupTables.ts Show resolved Hide resolved
@darthtrevino darthtrevino merged commit fab75db into main Nov 21, 2022
@darthtrevino darthtrevino deleted the task/resource_routes branch November 21, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natoverse natoverse natoverse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darthtrevino @natoverse