Add resource rename API

[darthtrevino]

No description provided.

[natoverse]

Ah, that makes sense - mapping-only probably just breezed past optional props with no fail Get Outlook for iOS<https://aka.ms/o0ukef>

________________________________ From: Chris Trevino ***@***.***> Sent: Wednesday, November 30, 2022 3:58:15 PM To: microsoft/datashaper ***@***.***> Cc: Nathan Evans ***@***.***>; Review requested ***@***.***> Subject: Re: [microsoft/datashaper] Add resource rename API (PR #440) @darthtrevino commented on this pull request.

________________________________ In javascript/workflow/src/resources/TableBundle.ts<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdatashaper%2Fpull%2F440%23discussion_r1036563403&data=05%7C01%7CNathan.Evans%40microsoft.com%7Cdbffaf0dfa4c4c4dc4de08dad32ebf0a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638054494977819558%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7J%2Ff12lbIyPE4wMEYO7DXLSRvf%2BnSE3YZb2uB%2B4Jb3A%3D&reserved=0>:

@@ -238,4 +245,12 @@ export class TableBundle extends Resource {

this.workflow.addInputs(this._inputs) } } + + private encode(inputTable: Maybe<ColumnTable>) { + return this.codebook != null && + this.codebook.fields.length > 0 && + inputTable != null + ? applyCodebook(inputTable, this.codebook, CodebookStrategy.MappingOnly) So the true error here is the first one I linked. I'm not sure why it causes two fixtures to fail, but processing the codebok schema in that example is the root cause. I'll double-check the fixture's codebook schema tomorrow - this one could be pretty old — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdatashaper%2Fpull%2F440%23discussion_r1036563403&data=05%7C01%7CNathan.Evans%40microsoft.com%7Cdbffaf0dfa4c4c4dc4de08dad32ebf0a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638054494977819558%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7J%2Ff12lbIyPE4wMEYO7DXLSRvf%2BnSE3YZb2uB%2B4Jb3A%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAFPZU6356GKV7K7YRQAQ2TWK7SZPANCNFSM6AAAAAASQCSAAE&data=05%7C01%7CNathan.Evans%40microsoft.com%7Cdbffaf0dfa4c4c4dc4de08dad32ebf0a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638054494977819558%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HeN94k8k7K4CWAKqE7Y6qfVpG3KqjxX1GQQcTLoVSpI%3D&reserved=0>. You are receiving this because your review was requested.Message ID: ***@***.***>