Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Workflow Verb #632

Merged
merged 13 commits into from
Feb 8, 2024
Merged

Implement Workflow Verb #632

merged 13 commits into from
Feb 8, 2024

Conversation

darthtrevino
Copy link
Member

@darthtrevino darthtrevino commented Feb 8, 2024

Implement the 'workflow' verb in Python to allow for sub-workflows. This verb is currently limited, in that sub-workflows can only accept a default input and emit a default output. Some more plumbing work in the datashaper internals will be required to arbitrary map-in input tables and draw-out output tables.

@darthtrevino darthtrevino requested a review from a team as a code owner February 8, 2024 01:35
Copy link
Contributor

@natoverse natoverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a root docs folder for verbs that should get an entry for this.

For UX I think we can avoid building anything complicated right now, but it would be nice if it doesn't throw - maybe at least a VerbForm that just says "Worklow steps cannot be displayed" or something, so the app is stable and informative while incomplete.

@darthtrevino darthtrevino merged commit fc6e56f into main Feb 8, 2024
12 checks passed
@darthtrevino darthtrevino deleted the feat/workflow_verb branch February 8, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants