Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scheduler] Simplified the poll function and deprecated the drop part. #840

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[scheduler] Simplified the poll function and deprecated the drop part. #840

merged 1 commit into from
Jul 11, 2023

Conversation

anandbonde
Copy link
Contributor

@anandbonde anandbonde commented Jul 11, 2023 •
edited
Loading

Simplified the poll function and deprecated the drop part.

@anandbonde anandbonde self-assigned this Jul 11, 2023
@anandbonde anandbonde changed the title [scheduler] Refactor and deprecate drop part [scheduler] Simplified the poll function and deprecated the drop part. Jul 11, 2023
iyzhang
iyzhang approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great! Thanks for cleaning up this code!

@anandbonde anandbonde force-pushed the enhancement-ab-deprecate-dropped-func branch from 02090ac to b11686a Compare July 11, 2023 10:04
@anandbonde anandbonde merged commit d979806 into dev Jul 11, 2023
@anandbonde anandbonde deleted the enhancement-ab-deprecate-dropped-func branch July 11, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@ppenna ppenna Awaiting requested review from ppenna

Assignees

@anandbonde anandbonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandbonde @iyzhang