Fix telemetry calls #124
Merged
Fix telemetry calls #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,8 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Licensed under the MIT License. See LICENSE in the project root for license information. | |||
|
|
|||
| #define TELEMETRYEVENTSOURCE_PUBLIC | |||
There was a problem hiding this comment.
This change is only to make it build correctly locally. With Unstub.ps1, this file is removed.
| @@ -28,7 +28,11 @@ public static void AccountStartupEvent(string eventName, string providerName, Li | |||
| } | |||
|
|
|||
| // TODO: Instead of LoginId, hash a globally unique id of DeveloperId (like url) | |||
| LoggerFactory.Get<ILogger>().Log($"{eventName}", LogLevel.Critical, $"{telemetryMessage}"); | |||
| LoggerFactory.Get<ILogger>().Log($"{eventName}", LogLevel.Critical, new | |||
| { | |||
There was a problem hiding this comment.
Should we make this a part of the api itself? So the WriteTelemetryEvent function can log this object. And we can set the the “field1” field to the object argument that is passed.
There was a problem hiding this comment.
Since this is the standard way I see other projects use this, I imagine there's a reason. But I don't know, maybe we can have an intermediate helper API. I wouldn't change DevHome.Telemetry project though, since that seems to be standard.
ujjwalchadha
approved these changes
Mar 29, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Fixes Telemetry calls for DevId.
References and relevant issues
#86
Detailed description of the pull request / Additional comments
Telemetry write calls should have Tagging as a field to be uploaded to Microsoft servers. Without tagging, the events will be blocked locally.
Validation steps performed
Ran Unstub.ps1 and ran TRTT locally to verify that the events show up locally.
PR checklist