Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third party notices link to Settings About #2718

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

nieubank
Copy link
Contributor

@nieubank nieubank commented Apr 22, 2024

Summary of the pull request

Adds link to view third party notices

References and relevant issues

#2717
https://task.ms/48892547

Detailed description of the pull request / Additional comments

This adds the notice.txt to Assets and launches via a hyperlink on the Settings/About page. This is done in the same manner as other preinstalled applications, e.g. Photos.

image

Validation steps performed

Navigate to Settings, About and click on Third Party Notices. Notice that the file is launched in the default text editor.

PR checklist

@krschau krschau added the Needs-Second Pull request that needs another approval label Apr 23, 2024
@nieubank nieubank merged commit 356fc88 into main Apr 23, 2024
4 checks passed
@nieubank nieubank deleted the user/nieubank/notice branch April 23, 2024 19:46
@krschau krschau removed the Needs-Second Pull request that needs another approval label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About should include a link to launch third party notices
3 participants