Enable plugins to restrict non-Microsoft hosts #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
reviewed
Mar 17, 2023
ujjwalchadha
approved these changes
Mar 17, 2023
asklar
reviewed
Mar 17, 2023
Comment on lines
+111
to
+121
| switch (valueStr) | ||
| { | ||
| case "Microsoft.Windows.DevHome_8wekyb3d8bbwe\0": | ||
| case "Microsoft.WindowsTerminal\0": | ||
| case "Microsoft.WindowsTerminal_8wekyb3d8bbwe\0": | ||
| case "WindowsTerminalDev_8wekyb3d8bbwe\0": | ||
| case "Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\0": | ||
| return true; | ||
| default: | ||
| return false; | ||
| } |
There was a problem hiding this comment.
replace with: starts with "Microsoft." ?
There was a problem hiding this comment.
We don't necessarily want any Microsoft app to have access (even though it's likely safe). There are also things that could fall out of that pattern. "WindowsTerminalDev" is one of them. In theory, we can give access to hosts outside of Microsoft as well as long as we trust them to not do anything malicious.
Ideally, this code all goes away and we use Custom Capabilities or something else more established than this. Unfortunately, Custom Capabilities look like they no longer work as expected...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Enable plugins to block COM clients that aren't approved Microsoft Dev Home plugin hosts.
References and relevant issues
#34
Detailed description of the pull request / Additional comments
Plugins can pass 'true' to RegisterPlugin() to restrict access to only approved Microsoft Dev Home plugin hosts. This works by querying the calling COM client for PackageFamilyName and comparing to a hardcoded list (currently Dev Home and Terminal). If the caller is not approved, plugin will return E_ACCESSDENIED.
Validation steps performed
Tested with local builds.
PR checklist