Fixing broken plugin lockdown check #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
reviewed
Mar 21, 2023
pluginsdk/Microsoft.Windows.DevHome.SDK.Lib/PluginInstanceManager.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Mar 21, 2023
pluginsdk/Microsoft.Windows.DevHome.SDK.Lib/PluginInstanceManager.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
asklar
reviewed
Mar 21, 2023
| @@ -81,16 +83,16 @@ private unsafe bool IsMicrosoftPluginHost() | |||
| return false; | |||
| } | |||
|
|
|||
| uint a = 0; | |||
| if (PInvoke.GetPackageFamilyNameFromToken((HANDLE)(IntPtr)(-6), &a, null) != WIN32_ERROR.ERROR_INSUFFICIENT_BUFFER) | |||
| uint buffer = 0; | |||
asklar
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Turns out GetCurrentThread() returns -2, while we want -5 or -6 (-6 is slightly better). -2 and -5 are both values for current thread pseudo-handle, but what you then use it for can make a difference. Switching to hard-coded value.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist