Remove unused banner control #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dkbennett
approved these changes
Mar 23, 2023
krschau
force-pushed
the
user/krschau/banner
branch
from
6bbcd57
to
71887f6
Compare
krschau
changed the title
krschau
force-pushed
the
user/krschau/banner
branch
from
71887f6
to
10890d3
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AmelBawa-msft
approved these changes
Mar 25, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
There is a banner control in DevHome.Common that replaced the one in DevHome.SetupFlow.MainPage. Delete the SetupFlow one, I think it may have accidentally been ported during the ADO->GitHub move.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Local validation.
PR checklist