Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DICOM Store Transaction #11

Merged
merged 8 commits into from
Jul 25, 2019
Merged

DICOM Store Transaction #11

merged 8 commits into from
Jul 25, 2019

Conversation

Richyl2
Copy link
Contributor

@Richyl2 Richyl2 commented Jul 16, 2019 •
edited
Loading

Description

The purpose of this PR is to implement the Store Transaction API.

  • Updated the Store message handler to properly inspect the incoming stream and store the results to the storage providers
  • Added a 'result builder' class to make sure the correct 'Dataset' and HTTP response codes are returned from a Store Transaction
  • Added and updated the Store end-to-end tests
  • Added DICOM conformance statement for the store transaction work

Testing

  • Updated the 'StoreTests' with more end-to-end tests for all the specific HTTP status codes and result datasets

@Richyl2 Richyl2 added the Area-DicomStore STOW-RS label Jul 16, 2019
@Richyl2 Richyl2 changed the base branch from personal/richyl2/metadata-blob-storage to master July 22, 2019 09:47
@Richyl2 Richyl2 marked this pull request as ready for review July 22, 2019 09:55
@Richyl2 Richyl2 requested a review from a team as a code owner July 22, 2019 09:55
@hansenms
Copy link

Looks good. I will let @brendankowitz sign off.

@Richyl2 Richyl2 merged commit 3f25e6b into master Jul 25, 2019
@jackliums jackliums deleted the personal/richyl2/dicom-store branch March 6, 2020 19:22
@npagare npagare mentioned this pull request Mar 27, 2022
Closed
@npagare npagare mentioned this pull request Jul 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier-alvarez javier-alvarez javier-alvarez approved these changes

@hansenms hansenms hansenms left review comments

@brendankowitz brendankowitz brendankowitz approved these changes

Assignees
No one assigned
Labels
Area-DicomStore STOW-RS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Richyl2 @hansenms @brendankowitz @javier-alvarez