Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descending to order by and remove the final order by #989

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Add descending to order by and remove the final order by #989

merged 2 commits into from
Sep 8, 2021

Conversation

smithago
Copy link
Contributor

@smithago smithago commented Sep 3, 2021 •
edited
Loading

Description

  • Bug in QIDO-RS paging. Study and Series level queries are not ordered desc during paging.
  • Also remove final order by because the results are already ordered during paging.

Related issues

AB#85053

Testing

Added/updated tests on paging generation

@smithago smithago requested a review from a team September 3, 2021 19:01
@smithago smithago marked this pull request as ready for review September 7, 2021 17:47
@smithago smithago merged commit 2234321 into main Sep 8, 2021
@smithago smithago deleted the personsal/smithasa/qido-page-fix branch September 8, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovinson-ms jovinson-ms jovinson-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smithago @jovinson-ms