devices responsiveness improvement and some nice to haves #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 18, 2022
added 4 commits
June 18, 2022 19:15
-updating header image on each page to leverage bootstrap and removing the .title-photo css class -removing the .accelerator-contributors css class -removing the .contributor-card css class -fixed responsiveness for contributors section of each of the 9 delivery accelerator pages (by updating the template and the get contributors script)
… header.css, and we're working to leverage bootstrap 5
… to leverage bootstrap 5
…nd how to contribute sections to leverage bootstrap. removing custom CSS classes no longer needed.
added 6 commits
June 18, 2022 21:15
…-box collapsing functionality. removing custom collapse menu functionality from script script-navbar.js as it's now taken care of by bootstrap!
…imple, bullet-pointed list
…lerator pages to be responsive by leverating bootstrap. updating accelerator guidance section to use a bootstrap 5 carousel instead of a custom css slider infinitiy class. replacing custom collapsible sections with bootstrap 5 collapsible sections.
|
things to rollback or fix comparing to Bogdan's version from Friday:
|
…ow to contribute videos, and contributors page
|
more responsiveness issues to fix:
|
added 4 commits
June 21, 2022 11:03
…he page - needs to be fixed
…table in div with bs5 class table-responsive. also styling the table with bs5 class table.
…ccelerator template
… grid system for responsiveness
|
going to move this remaining change out and into its own separate PR, so we can proceed with the PR for the many changes completed so far!
Moved to separate PR: #92 |
mtran-affirma
changed the title
This was
linked to
issues
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(done) implementation of responsiveness for all pages by leveraging Bootstrap 5 and refactoring all code to leverage Bootstrap 5 functionality:
-- (done) Navigation Bar
-- (done) Home page
-- (done) Toolkit page
----- (done) 9 accelerator pages
-- (done) How to Contribute page
-- (done) Contributors page
-- (done) Footer
(done)Accelerator Pages - Prerequisites should be simple bullet pointed list (like the Industries list) Accelerator Pages - Prerequisites should be simple bullet pointed list #58
(done) Add hyperlink to DS toolkit logo Add hyperlink to DS toolkit logo #78