-
Notifications
You must be signed in to change notification settings - Fork 15
Implement suspend and resume client APIs #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration tests passed on local on latest durabletask-sidecar. |
@kaibocai great! So the next step for me is to update the sidecar container used by the CI. Can you also open an issue that tracks updating this documentation? https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-instance-management?tabs=java#suspend-and-resume-instances-preview |
Create issue #105 to track document update |
client/src/test/java/com/microsoft/durabletask/IntegrationTests.java
Outdated
Show resolved
Hide resolved
client/src/test/java/com/microsoft/durabletask/IntegrationTests.java
Outdated
Show resolved
Hide resolved
client/src/test/java/com/microsoft/durabletask/IntegrationTests.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java
Show resolved
Hide resolved
Hi @cgillum , I have updated the unit tests (combine redundant tests and add one for testing termination). I found an issue in sidecar for method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple small suggestions before merging.
client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcClient.java
Show resolved
Hide resolved
client/src/test/java/com/microsoft/durabletask/IntegrationTests.java
Outdated
Show resolved
Hide resolved
Updated the sidecar, all tests pass. Merging this PR! |
|
Issue describing the changes in this PR
resolves #96
Pull request checklist
Create issue Update document for milestone v1.2.0 #105 to track document update
CHANGELOG.md
Additional information
Additional PR information