Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulate NMR API failures: Fix SIGSEGV crashes #2268

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

shpalani
Copy link
Collaborator

@shpalani shpalani commented Apr 3, 2023

Description

This PR addresses 3 crashes when fault injection is enabled in nmr apis.

Please see the details of call stack in #2101

Testing

Do any existing tests cover this change? Yes
Are new tests needed?
No

Documentation

Is there any documentation impact for this change? No

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #2268 (ee6669c) into main (21300ed) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
- Coverage   83.61%   83.57%   -0.05%     
==========================================
  Files         151      151              
  Lines       28276    28279       +3     
==========================================
- Hits        23643    23633      -10     
- Misses       4633     4646      +13     
Impacted Files Coverage Δ
libs/execution_context/ebpf_native.c 90.47% <100.00%> (-0.39%) ⬇️
libs/execution_context/ebpf_program.c 82.85% <100.00%> (+0.01%) ⬆️
libs/platform/user/nmr_impl.cpp 87.04% <100.00%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dthaler
dthaler previously requested changes Apr 3, 2023
Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code doesn't match SAL annotation.
Please fix one or the other.

@dthaler dthaler enabled auto-merge April 4, 2023 20:01
@dthaler dthaler added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 4, 2023
@shpalani shpalani added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 4, 2023
@shpalani shpalani added this pull request to the merge queue Apr 4, 2023
Merged via the queue into microsoft:main with commit 7502790 Apr 4, 2023
@shpalani shpalani deleted the shpalan/nmr-api-failure-fix-3 branch April 4, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulate NMR and OS API failures
3 participants