-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate NMR API failures: Fix SIGSEGV crashes #2268
Simulate NMR API failures: Fix SIGSEGV crashes #2268
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2268 +/- ##
==========================================
- Coverage 83.61% 83.57% -0.05%
==========================================
Files 151 151
Lines 28276 28279 +3
==========================================
- Hits 23643 23633 -10
- Misses 4633 4646 +13
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code doesn't match SAL annotation.
Please fix one or the other.
Description
This PR addresses 3 crashes when fault injection is enabled in nmr apis.
Please see the details of call stack in #2101
Testing
Do any existing tests cover this change? Yes
Are new tests needed? No
Documentation
Is there any documentation impact for this change? No