Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W-1] Prep work for watchers #16

Merged
merged 9 commits into from
Jun 22, 2017
Merged

[W-1] Prep work for watchers #16

merged 9 commits into from
Jun 22, 2017

Conversation

connor4312
Copy link
Member

This is the first part of a stacked PR which implements etcd watchers.

In this PR, I do some prep work before addign watchers:

  • Some misc typing fixes in rpc.ts / the method generators
  • Added a GRPC proxy server that we'll use later to simulate bad networks and crashed servers
  • Added a patch for a GRPC bug which would otherwise cause crashes in bad network conditions

test/util.ts Outdated
* activate creates the proxy server.
*/
public activate(): Promise<void> {
return new Promise<void>(resolve => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reject on error.

@connor4312 connor4312 dismissed SimonSchick’s stale review June 22, 2017 04:17

Comments addressed

@connor4312 connor4312 merged commit c187c32 into master Jun 22, 2017
@connor4312 connor4312 deleted the watchers-final branch June 22, 2017 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants