Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Removal of @microsoft/eslint-config-fast-dna #6948

Closed
janechu opened this issue May 5, 2024 · 0 comments · Fixed by #6970
Closed

RFC: Removal of @microsoft/eslint-config-fast-dna #6948

janechu opened this issue May 5, 2024 · 0 comments · Fixed by #6970

Comments

@janechu
Copy link
Collaborator

janechu commented May 5, 2024

Removal of @microsoft/eslint-config-fast-dna

Reason for removal

The eslint rules package is not something we would recommend others take a dependency on and we are actively re-evaluating the current ruleset.

@janechu janechu added this to the FAST Element 2.0 milestone May 5, 2024
janechu added a commit that referenced this issue May 24, 2024
# Pull Request

## 📖 Description

Removal of the `@microsoft/eslint-config-fast-dna` package as we reserve the right to change eslint configurations and will not be maintaining a package outside this repository. As such, the configuration options have been moved to the root `.eslintrc`.

### 🎫 Issues

Resolves #6948

## 👩‍💻 Reviewer Notes

The logic has not changed here, we are only moving this package configuration options internal, and I have added "prettier" as an extension as all current packages re-extend it anyway.

## ✅ Checklist

### General

<!--- Review the list and put an x in the boxes that apply. -->

- [x] I have included a change request file using `$ yarn change`
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
- [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project.
janechu added a commit that referenced this issue Jun 10, 2024
# Pull Request

## 📖 Description

Removal of the `@microsoft/eslint-config-fast-dna` package as we reserve the right to change eslint configurations and will not be maintaining a package outside this repository. As such, the configuration options have been moved to the root `.eslintrc`.

### 🎫 Issues

Resolves #6948

## 👩‍💻 Reviewer Notes

The logic has not changed here, we are only moving this package configuration options internal, and I have added "prettier" as an extension as all current packages re-extend it anyway.

## ✅ Checklist

### General

<!--- Review the list and put an x in the boxes that apply. -->

- [x] I have included a change request file using `$ yarn change`
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
- [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant