Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct anchor and button stylesheets #3308

Merged
merged 6 commits into from
Jun 15, 2020

Conversation

nicholasrice
Copy link
Contributor

@nicholasrice nicholasrice commented Jun 15, 2020

Description

Several issues outlined in #3269 were making styling buttons and anchors difficult. While there still exists some complexity in styling padding / borders, this PR aims to reduce the styling edge-cases that arise from the implementation details of both fast-button and fast-anchor.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever solution with the transparent bg on the control itself 👍

@nicholasrice nicholasrice merged commit 78feda2 into master Jun 15, 2020
@nicholasrice nicholasrice deleted the users/nirice/correct-element-styles branch June 15, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants