-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Safari 16 adoptNode issue #6644
Conversation
@microsoft-github-policy-service agree company="Fevo" |
"comment": "Fix Safari 16 adoptNode issue", | ||
"packageName": "@microsoft/fast-element", | ||
"email": "mahwy.asdf@gmail.com", | ||
"dependentChangeType": "patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dependentChangeType": "patch" | |
"dependentChangeType": "prerelease" |
@@ -0,0 +1,7 @@ | |||
{ | |||
"type": "patch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"type": "patch", | |
"type": "prerelease", |
This appears to have been fixed by Safari via WebKit/WebKit#11347 |
Pull Request
📖 Description
Safari 16+ introduced a breaking change with
adoptNode
. It's providing a fix by callingimportNode
in case the adoptNode returned preemptively without adopting a given fragment.🎫 Issues
fast-router
templates not attaching on safari 16+ #6537👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn change