Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safari 16 adoptNode issue #6644

Closed
wants to merge 3 commits into from
Closed

Conversation

mahwy
Copy link

@mahwy mahwy commented Feb 17, 2023

Pull Request

📖 Description

Safari 16+ introduced a breaking change with adoptNode. It's providing a fix by calling importNode in case the adoptNode returned preemptively without adopting a given fragment.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@mahwy
Copy link
Author

mahwy commented Feb 17, 2023

@mahwy please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Fevo"

@mahwy mahwy changed the title Fix Safari 16 adoptNode issue fix: Safari 16 adoptNode issue Feb 17, 2023
"comment": "Fix Safari 16 adoptNode issue",
"packageName": "@microsoft/fast-element",
"email": "mahwy.asdf@gmail.com",
"dependentChangeType": "patch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dependentChangeType": "patch"
"dependentChangeType": "prerelease"

@@ -0,0 +1,7 @@
{
"type": "patch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "patch",
"type": "prerelease",

@janechu
Copy link
Collaborator

janechu commented May 30, 2024

This appears to have been fixed by Safari via WebKit/WebKit#11347

@janechu janechu closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants