fix: only add aria orientation for proper role divider #6771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
requested review from
EisenbergEffect and
nicholasrice
as code owners
packages/web-components/fast-foundation/src/divider/divider.template.ts
Outdated
Show resolved
Hide resolved
chrisdholt
force-pushed
the
users/chhol/only-add-aria-orientation-for-proper-role-divider
branch
3 times, most recently
from
463b5fc
to
83ceda4
Compare
chrisdholt
force-pushed
the
users/chhol/only-add-aria-orientation-for-proper-role-divider
branch
from
83ceda4
to
1c0bf15
Compare
…proper-role-divider
nicholasrice
approved these changes
Jul 17, 2023
eljefe223
approved these changes
Jul 17, 2023
chrisdholt
deleted the
users/chhol/only-add-aria-orientation-for-proper-role-divider
branch
This was referenced Oct 19, 2023
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* fix: add aria-orientation to divider only when role equals separator * Change files * pass role in test * pri exclusion in template logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR ensures that aria-attributes are allowed for a given role for Divider. In cases where the role is presentation,
aria-orientationshould not be applied.🎫 Issues
n/a