fix(fast-element1): fix toolbar navigation tests #6976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Ten of the fast-foundation toolbar tests (related to focus) began failing seemingly due to browser changes. The tests fail in Chrome as well as Firefox. It seems that calling
focus()
on the toolbar element does not pass the focus on to a contained element. I've worked around this for nine of the tests by directly focusing a button initially, instead of focusing the toolbar and expecting the button to get focus. The tenth failing test is testing exactly the behavior that stopped working. I believe we will have to just disable that test.Also, removing a stray
.only
that was apparently checked in accidentally.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn change
⏭ Next Steps