Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rollup docs for v1 #6982

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix rollup docs for v1 #6982

merged 1 commit into from
Jun 11, 2024

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Jun 10, 2024

Pull Request

📖 Description

The rollup configuration docs for FAST Element v1 cause corrupted HTML, this change ports over validated configuration options used in Fluent UI web components.
 

🎫 Issues

Closes #6795

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu self-assigned this Jun 10, 2024
@janechu janechu merged commit 62af44f into master Jun 11, 2024
10 checks passed
@janechu janechu deleted the users/janechu/fix-rollup-docs-v1 branch June 11, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radium-v radium-v radium-v approved these changes

@chrisdholt chrisdholt chrisdholt approved these changes

@awentzel awentzel Awaiting requested review from awentzel awentzel is a code owner

@Falkicon Falkicon Awaiting requested review from Falkicon Falkicon is a code owner

Assignees

@janechu janechu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janechu @radium-v @chrisdholt