Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes infinite loop in ConditionalDelete #2269

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Fixes infinite loop in ConditionalDelete #2269

merged 1 commit into from
Oct 7, 2021

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Oct 7, 2021 •
edited
Loading

Description

Fixes infinite loop in ConditionalDelete

Related issues

Addresses AB#85825 and #2265

Testing

Adds tests

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
  • Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
  • Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@brendankowitz brendankowitz requested a review from a team as a code owner October 7, 2021 20:11
namadabu
namadabu approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@namadabu namadabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brendankowitz brendankowitz merged commit 7629037 into main Oct 7, 2021
@brendankowitz brendankowitz deleted the personal/bkowitz/conditional-delete-loop branch October 7, 2021 22:11
brendankowitz added a commit that referenced this pull request Oct 8, 2021
@brendankowitz
Fixes infinite loop in ConditionalDelete (#2269)
703b004
@brendankowitz brendankowitz added Bug-Performance Performance related bugs. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namadabu namadabu namadabu approved these changes

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug-Performance Performance related bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendankowitz @namadabu